[9.3](backport #52005) [beatreceiver][packetbeat] Delegate shutdown_timeout logic to libbeat - #52267
[9.3](backport #52005) [beatreceiver][packetbeat] Delegate shutdown_timeout logic to libbeat#52267mergify[bot] wants to merge 2 commits into
Conversation
|
Cherry-pick of 663f454 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
🤖 GitHub commentsJust comment with:
|
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏 |
TL;DRThe Buildkite failure is caused by unresolved cherry-pick conflict markers committed in Remediation
Investigation detailsRoot CauseThis backport contains the literal Git conflict markers from the failed cherry-pick. The PR diff shows markers in both files: Evidence
VerificationNot run locally; the supplied CI logs fail during formatting and pre-commit before tests execute. Follow-upThe PR already has a What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Adapt #52005 to 9.3 by adding Beat.ShutdownTimeout for the beater assignment and switching the processor flush wait to publish_timeout, without pulling main-only logger changes. Assisted-By: Composer Co-authored-by: Cursor <cursoragent@cursor.com>
|
Resolved the cherry-pick conflicts and pushed. 9.3 adaptation: Packetbeat beater/config compile cleanly locally. |
TL;DRThe Remediation
Investigation detailsRoot CauseThe PR head introduces or exposes four lint violations in the touched Packetbeat files: forbidden global logger usage, the Evidence
ValidationNot run locally; this report is based on the failed workflow logs and PR-head source. Follow-upThe earlier detective report on this PR covered unresolved cherry-pick conflict markers in Buildkite. This report covers a different failure in the subsequent What is this? | From workflow: PR Actions Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Proposed commit message
This PR delegates
shutdown_timeoutlogic to libbeat. It stays consistent with how other beats also handle the same.This is also required so that we do not wait for
shutdown_timeoutperiod every time the config is validated hereChecklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None
Will also close #52031
This is an automatic backport of pull request #52005 done by Mergify.